----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46829/#review134992 -----------------------------------------------------------
kms/src/main/java/org/apache/hadoop/crypto/key/RangerHSM.java (line 109) <https://reviews.apache.org/r/46829/#comment199980> Colm - Patch does not apply on master branch. Please check. Also, please update BUG and BRANCH fields in the review request. $ git apply --check -v < ~/Downloads/patches/ranger/0001-RANGER-961-Remove-KMS-xml-security-impl-dependency.patch Checking patch kms/pom.xml... Checking patch kms/src/main/java/org/apache/hadoop/crypto/key/DB2HSMMKUtil.java... Checking patch kms/src/main/java/org/apache/hadoop/crypto/key/HSM2DBMKUtil.java... Checking patch kms/src/main/java/org/apache/hadoop/crypto/key/RangerHSM.java... Hunk #2 succeeded at 90 (offset 1 line). error: while searching for: if (result == true) { logger.debug("Ranger Master Key is present in Keystore"); SecretKey key = (SecretKey)myStore.getKey(alias, password.toCharArray()); String masterKey = Base64.encode(key.getEncoded()) ; return masterKey; } } catch (Exception e) { error: patch failed: kms/src/main/java/org/apache/hadoop/crypto/key/RangerHSM.java:109 error: kms/src/main/java/org/apache/hadoop/crypto/key/RangerHSM.java: patch does not apply Checking patch kms/src/main/java/org/apache/hadoop/crypto/key/RangerMasterKey.java... - Velmurugan Periasamy On April 29, 2016, 10:43 a.m., Colm O hEigeartaigh wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/46829/ > ----------------------------------------------------------- > > (Updated April 29, 2016, 10:43 a.m.) > > > Review request for ranger. > > > Repository: ranger > > > Description > ------- > > The KMS module uses the xml-security-impl dependency just to get a Base64 > encoder/decoder. This is not necessary as one is already available in Commons > Codec, and in fact is used in other classes in this module. > > > Diffs > ----- > > kms/pom.xml a9f6c6c > kms/src/main/java/org/apache/hadoop/crypto/key/DB2HSMMKUtil.java ca69dc0 > kms/src/main/java/org/apache/hadoop/crypto/key/HSM2DBMKUtil.java 73a5830 > kms/src/main/java/org/apache/hadoop/crypto/key/RangerHSM.java 6ab91d9 > kms/src/main/java/org/apache/hadoop/crypto/key/RangerMasterKey.java d70ec4e > > Diff: https://reviews.apache.org/r/46829/diff/ > > > Testing > ------- > > > Thanks, > > Colm O hEigeartaigh > >
