----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48104/#review135735 -----------------------------------------------------------
Ship it! Ship It! - Madhan Neethiraj On June 1, 2016, 12:45 a.m., Abhay Kulkarni wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/48104/ > ----------------------------------------------------------- > > (Updated June 1, 2016, 12:45 a.m.) > > > Review request for ranger and Madhan Neethiraj. > > > Bugs: RANGER-1009 > https://issues.apache.org/jira/browse/RANGER-1009 > > > Repository: ranger > > > Description > ------- > > If the service-name is reused, then under some conditions, ranger returned a > cached (and stale) version of the service which was replaced by the new > service with the same name. The fix involved ensuring that both service-name > and service-id are matched in order that cached copy is used, otherwise, > cache is refreshed from persistent store before it is used. > > > Diffs > ----- > > security-admin/src/main/java/org/apache/ranger/biz/ServiceDBStore.java > d2178f4 > security-admin/src/main/java/org/apache/ranger/biz/TagDBStore.java 5f298d9 > > security-admin/src/main/java/org/apache/ranger/common/RangerServicePoliciesCache.java > b712f09 > > security-admin/src/main/java/org/apache/ranger/common/RangerServiceTagsCache.java > 15af0f0 > > Diff: https://reviews.apache.org/r/48104/diff/ > > > Testing > ------- > > A service and some policies within the service are created. Then the service > was deleted without modifying anything in the service or contained policies. > Subsequently, a service with the same name was created with some containing > policies. The service was retrieved by name, and ensured that ranger returned > new service and contained policies. > > > Thanks, > > Abhay Kulkarni > >
