-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48117/
-----------------------------------------------------------
Review request for ranger, Don Bosco Durai, Gautam Borad, Abhay Kulkarni,
Madhan Neethiraj, Pradeep Agrawal, Ramesh Mani, Selvamohan Neethiraj, Sailaja
Polavarapu, and Velmurugan Periasamy.
Bugs: RANGER-1000
https://issues.apache.org/jira/browse/RANGER-1000
Repository: ranger
Description
-------
**Problem statement: **
Tag service deletion is failing when it is associated with a resource based
service. Ranger UI should return proper error message if any tag service is
associated with any resource based service.
**Proposed Solution: **
Proposed solution contain changes in Delete Service REST where if delete
request is for 'Tag' service then its assoication will be checked. if service
is 'Tag' service and if it is associated in any Resource based service then
delete request will not be processed and error message will appear in UI.
Diffs
-----
agents-common/src/main/java/org/apache/ranger/plugin/model/validation/RangerPolicyValidator.java
0bdaf87
security-admin/src/main/java/org/apache/ranger/rest/ServiceREST.java 1028c8d
security-admin/src/main/webapp/scripts/views/policymanager/ServiceLayout.js
aae7543
Diff: https://reviews.apache.org/r/48117/diff/
Testing
-------
**Steps performed(With patch): **
1. Installed Ranger and Started Ranger.
2. Login to Ranger admin from 'admin' user and created a 'Tag' service 'tagdev'
3. Created Resource based services of different type(HDFS,HIVE,HBASE etc) and
associate 'tagdev' as Tag in those services.
4. Clicked on delete button provided against 'tagdev' service
**Expected Behaviour: **
'tagdev' service should not be deleted and error message should appear in UI
which shall have the number of services where 'tagdev' is being referenced and
the list of service names wherever it is associated.
**Actual Behaviour: **
Error message in Ranger UI was : "Tag service 'tagdev' is being referenced by 2
services: [hadoopdev,hbasedev]"
'tagdev' service deletion was failed and 'tagdev' service can be seen after
reloading the tag based policy from menu.
Thanks,
Pradeep Agrawal
