----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48066/#review135894 -----------------------------------------------------------
Ship it! Ship It! - Velmurugan Periasamy On May 31, 2016, 9:52 a.m., Gautam Borad wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/48066/ > ----------------------------------------------------------- > > (Updated May 31, 2016, 9:52 a.m.) > > > Review request for ranger, Don Bosco Durai, Abhay Kulkarni, Madhan Neethiraj, > Pradeep Agrawal, and Velmurugan Periasamy. > > > Bugs: RANGER-1004 > https://issues.apache.org/jira/browse/RANGER-1004 > > > Repository: ranger > > > Description > ------- > > Currently, the UI for row level filtering, column masking, the user needs to > explicitly choose access type while setting up a policy in the UI. The access > type has only one choice, "select" > > It seems very redundant. Suggestion to keep "select" as default access type > whenever someone is creating a policy. > > > Diffs > ----- > > security-admin/src/main/webapp/scripts/utils/XAEnums.js bebb02c > security-admin/src/main/webapp/scripts/utils/XAUtils.js e2aab57 > security-admin/src/main/webapp/scripts/views/policies/PermissionList.js > 788e729 > security-admin/src/main/webapp/scripts/views/policies/RangerPolicyForm.js > ea0cd0e > > security-admin/src/main/webapp/templates/policies/RangerPolicyForm_tmpl.html > 3937696 > > Diff: https://reviews.apache.org/r/48066/diff/ > > > Testing > ------- > > Verified following scenarios : > > 1) When policy is added in Masking and Row Level Filtering in Access Type > 'select' option get added by default > > 2) In Masking and Row Level Filter Allow Condition label has been changed to > 'Mask Conditions' and 'Row Filter Conditions' > > 3) In row level filter type, users and groups are getitng added properly. > > 4) Policy CRUD working as expected > > > Thanks, > > Gautam Borad > >
