----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48337/#review136461 -----------------------------------------------------------
Ship it! Ship It! - Velmurugan Periasamy On June 7, 2016, 12:20 p.m., Pradeep Agrawal wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/48337/ > ----------------------------------------------------------- > > (Updated June 7, 2016, 12:20 p.m.) > > > Review request for ranger, Ankita Sinha, Don Bosco Durai, Gautam Borad, Abhay > Kulkarni, Madhan Neethiraj, Mehul Parikh, Ramesh Mani, Selvamohan Neethiraj, > and Velmurugan Periasamy. > > > Bugs: RANGER-1005 > https://issues.apache.org/jira/browse/RANGER-1005 > > > Repository: ranger > > > Description > ------- > > **Problem Statement:** Password change utility should have reference of all > jars of ews/lib also and perform password validation before proceeding to > change password. > > **Proposed Solution:** > 1. Added ews/lib/ in classpath. > 2. Added password validation method. > > > Diffs > ----- > > security-admin/scripts/changepasswordutil.py c6025f3 > > Diff: https://reviews.apache.org/r/48337/diff/ > > > Testing > ------- > > **Steps Performed(with patch):** > 1. Installed ranger-admin from Build having changed of proposed patch. > 2. Go to ranger-admin installation directory. > 3. Run below given command to change 'admin' user password from 'admin' to > 'admin123' > python changepasswordutil.py admin admin admin123 > 4. Started ranger-admin and tried to access ranger-admin home page/login page > 5. On the login page of ranger-admin entered username 'admin' and password > 'admin123'; clicked on 'Sign In' button to login page. > > Expected Behavior: > 'admin' user should get authenticated successfully and ranger-admin dashboard > page for 'admin' user should appear. > > Actual Behavior: > 'admin' user was authenticated successfully and after authentication page was > redirected to ranger-admin dashboard page. > > **Note :** Tested the above steps by providing unsupported characters at new > password argument position and executed command to change password; password > change execution failed with message 'password contains one of the > unsupported special characters like \" ' \ `' > > > Thanks, > > Pradeep Agrawal > >
