----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48505/#review136882 -----------------------------------------------------------
agents-common/src/main/java/org/apache/ranger/plugin/policyengine/RangerAccessRequestImpl.java (line 138) <https://reviews.apache.org/r/48505/#comment201987> The return value from this method is needed/used only for audit. Consider moving getAdditionalInfo() method/functionalty from RangerAccessRequest to audit module. agents-common/src/main/java/org/apache/ranger/plugin/policyengine/RangerAccessRequestImpl.java (line 247) <https://reviews.apache.org/r/48505/#comment201988> I think it will be useful to specify the property name (for trustedProxyAddresses) here. Also, this warn log might endup filling the log files. Consider moving this warn log to the place where useForwardedIPAddress and trustedProxyAddresses configuration values are read - RangerBasePlugin.java agents-common/src/test/resources/policyengine/test_policyengine_hdfs.json (line 107) <https://reviews.apache.org/r/48505/#comment201991> Consider using clientIPAddress in some test cases. - Madhan Neethiraj On June 9, 2016, 7:27 p.m., Abhay Kulkarni wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/48505/ > ----------------------------------------------------------- > > (Updated June 9, 2016, 7:27 p.m.) > > > Review request for ranger and Madhan Neethiraj. > > > Bugs: RANGER-962 > https://issues.apache.org/jira/browse/RANGER-962 > > > Repository: ranger > > > Description > ------- > > Enhancements to policy evaluation infrastructure for supporting > X-Forwarded-For address if specified by the component > > > Diffs > ----- > > > agents-audit/src/main/java/org/apache/ranger/audit/model/AuthzAuditEvent.java > 55dc448 > > agents-common/src/main/java/org/apache/ranger/authorization/hadoop/constants/RangerHadoopConstants.java > ac9e93d > > agents-common/src/main/java/org/apache/ranger/plugin/audit/RangerDefaultAuditHandler.java > bfb9126 > > agents-common/src/main/java/org/apache/ranger/plugin/policyengine/RangerAccessRequest.java > 4a2aef8 > > agents-common/src/main/java/org/apache/ranger/plugin/policyengine/RangerAccessRequestImpl.java > c4550c4 > > agents-common/src/main/java/org/apache/ranger/plugin/policyengine/RangerAccessRequestReadOnly.java > 339aac5 > > agents-common/src/main/java/org/apache/ranger/plugin/policyengine/RangerPolicyEngine.java > e5f1132 > > agents-common/src/main/java/org/apache/ranger/plugin/policyengine/RangerPolicyEngineImpl.java > e6e9a3a > > agents-common/src/main/java/org/apache/ranger/plugin/service/RangerBasePlugin.java > 9b7cae8 > > agents-common/src/test/java/org/apache/ranger/plugin/policyengine/TestPolicyEngine.java > 6bb7486 > agents-common/src/test/resources/policyengine/test_policyengine_geo.json > eab1223 > agents-common/src/test/resources/policyengine/test_policyengine_hdfs.json > a7f355c > agents-common/src/test/resources/policyengine/test_policyengine_hive.json > 4151a87 > > Diff: https://reviews.apache.org/r/48505/diff/ > > > Testing > ------- > > Ran unit tests successfully. > > > Thanks, > > Abhay Kulkarni > >
