[ 
https://issues.apache.org/jira/browse/RANGER-964?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15335925#comment-15335925
 ] 

Gautam Borad commented on RANGER-964:
-------------------------------------


+Minor issues:+
* LICENSE is missing MIT licensed Search Icon CSS copyright Nicolas Gallagher 
bundled in (1)
**  Added PURE CSS GUI ICONS to LICENSE.txt
* Is the copyright on this files correct? (2)(3) if so what projects did they 
come from? (may effect content of NOTICE file)
** (2) -> Added Jisql license. 
** (3) -> This file comes with Spring Security. Added that to LICENSE.txt
* LICENSE is missing MIT licensed es5-shim copyright Kristopher Michael Kowal 
bundled in (4)
** Added to LICENSE.txt
* LICENSE is missing SIL licensed FontAwesome (9)
** Added to LICENSE.txt
* LICENSE is missing reset.css. (7) Note this version bundled may not be public 
domain unlike this one (8) so you may need to sort that out.
** Added a note in LICENSE.txt
* LICENSE is missing MIT licensed sizzle.js bundled in several files (10)
** Added to LICENSE.txt
* LICENSE is missing MIT license javascript diff engine in (11)
** File was not used, removed the file.
* I think handle bars require plugin is not WTFPL but MIT or BSD? (12) May 
require further investigation.
** Added a note in LICENSE.txt
* LICENSE is missing public domain json2.js (13)
** Added to LICENSE.txt
* LICENSE is missing BSD licensed easing equations from Robert Penner (15) in 
this file (14)
** Added a note in LICENSE.txt

+This is a more serious concern (and has been asked before):+
* How is this file licensed? (5) or this one? (6)
** These files are not used, removed the files.

> Fix NOTICE and LICENSE file contents
> ------------------------------------
>
>                 Key: RANGER-964
>                 URL: https://issues.apache.org/jira/browse/RANGER-964
>             Project: Ranger
>          Issue Type: Bug
>          Components: Ranger
>            Reporter: Velmurugan Periasamy
>            Assignee: Gautam Borad
>             Fix For: 0.6.0
>
>         Attachments: 
> 0001-RANEGR-964-updated-copyright-years-NOTICE-file-conte.patch, 
> 0001-RANGER-964-Fix-LICENSE.txt.patch, 
> 0001-RANGER-964-Fix-licensing-ordering-in-the-headers.patch, 
> 0001-RANGER-964-cleanup-LICENSE.txt-for-not-used-librarie.patch, 
> RANGER-964.2.patch, RANGER-964.3.patch
>
>
> Following content needs to be fixed. Came out from IPMC review.
> - docs/NOTICE - this seems to be referring to Apache Maven Site Plugin, not
> Ranger
> - NOTICE.txt - wrong copyright years (pre-incubation?)



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to