----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48887/#review138355 -----------------------------------------------------------
tagsync/src/main/java/org/apache/ranger/tagsync/source/atlas/AtlasNotificationMapper.java (line 49) <https://reviews.apache.org/r/48887/#comment203532> Consider moving all the logic of logging/not-logging into a single method; this can enable printing of more data like number of notifications skipped, etc (similar to audit statistics). reportUnhandledEntityNotification(EntityNotification notification) { // } - Madhan Neethiraj On June 17, 2016, 11:30 p.m., Abhay Kulkarni wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/48887/ > ----------------------------------------------------------- > > (Updated June 17, 2016, 11:30 p.m.) > > > Review request for ranger and Madhan Neethiraj. > > > Bugs: RANGER-1042 > https://issues.apache.org/jira/browse/RANGER-1042 > > > Repository: ranger > > > Description > ------- > > Review and update logging to reduce clutter in tagsync debug log. > > If tagsync fails to initialize any tag-sources successfully, warning message > is logged. Also, when tagsync receives notification for an unhandled event > type, it is logged selectively (only one message in 5 minutes) to avoid > cluttering logs with not-so-useful messages. > > > Diffs > ----- > > > tagsync/src/main/java/org/apache/ranger/tagsync/process/TagSynchronizer.java > ac4dcd0 > > tagsync/src/main/java/org/apache/ranger/tagsync/source/atlas/AtlasNotificationMapper.java > 510732b > > tagsync/src/main/java/org/apache/ranger/tagsync/source/atlas/AtlasTagSource.java > fe54cd4 > > Diff: https://reviews.apache.org/r/48887/diff/ > > > Testing > ------- > > > Thanks, > > Abhay Kulkarni > >
