----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48864/#review138746 -----------------------------------------------------------
Ship it! Ship It! - Velmurugan Periasamy On June 17, 2016, 6:47 p.m., Pradeep Agrawal wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/48864/ > ----------------------------------------------------------- > > (Updated June 17, 2016, 6:47 p.m.) > > > Review request for ranger, Alok Lal, Don Bosco Durai, Gautam Borad, Abhay > Kulkarni, Madhan Neethiraj, Ramesh Mani, Selvamohan Neethiraj, and Velmurugan > Periasamy. > > > Bugs: RANGER-1040 > https://issues.apache.org/jira/browse/RANGER-1040 > > > Repository: ranger > > > Description > ------- > > **Problem Statement:** Currently user_name column of x_user table does not > have unique constraint and validation is done only in Ranger admin; > Concurrent request to create user might create issue or table may have more > than one user with same user_name. > > **Proposed Solution:** > 1. Add Unique key/constraint on user_name column of x_user table. > 2. Change the size(767) of user_name column according to login_id column of > x_portal_user. > > > Diffs > ----- > > > security-admin/db/mysql/patches/023-add-unique-constraint-on-table-x_user.sql > PRE-CREATION > > security-admin/db/oracle/patches/023-add-unique-constraint-on-table-x_user.sql > PRE-CREATION > > security-admin/db/postgres/patches/023-add-unique-constraint-on-table-x_user.sql > PRE-CREATION > > security-admin/db/sqlanywhere/patches/023-add-unique-constraint-on-table-x_user.sql > PRE-CREATION > > security-admin/db/sqlserver/patches/023-add-unique-constraint-on-table-x_user.sql > PRE-CREATION > > Diff: https://reviews.apache.org/r/48864/diff/ > > > Testing > ------- > > Steps Performed (with patch) : > 1. After Build untar the Ranger module and updated install.properties for > MySQL DB flavor. > 2. Called setup.sh to install Ranger. > > Expected Behavior : > 1. Ranger installation should finish successfully and UNIQUE key constraint > should be created on user_name column of x_user table. > 2. Ranger UI should work. > > Actual Behavior : > 1. Ranger Installtion finished successfully and unique key got created on > user_name column of x_user table. > 2. Started Ranger Admin and was able to login in Ranger UI. > > Note: Patch is working for all other DB Flavors. > > > Thanks, > > Pradeep Agrawal > >
