----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49009/#review138908 -----------------------------------------------------------
Ship it! Ship It! - Velmurugan Periasamy On June 21, 2016, 8:29 a.m., Mehul Parikh wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/49009/ > ----------------------------------------------------------- > > (Updated June 21, 2016, 8:29 a.m.) > > > Review request for ranger, Don Bosco Durai, Gautam Borad, Abhay Kulkarni, > Madhan Neethiraj, Pradeep Agrawal, Ramesh Mani, and Velmurugan Periasamy. > > > Bugs: RANGER-709 > https://issues.apache.org/jira/browse/RANGER-709 > > > Repository: ranger > > > Description > ------- > > **Problem Statement :** > Currently Ranger Admin allows users to enter multiple values to custom > conditions - like "ip-range" condition, in which users can enter multiple > values. This works for most conditions. However, there are conditions that > expect a single value from the user - like a boolean value. For such > conditions, Ranger Admin should allow the user to enter only one value. For > example, this will be useful for a condition like "accessed-after-expiry" - > which expects the user to enter either "yes" or "no". > > Ranger Admin can use uiHint "singleValue=true" in the condition-def to > determine whether to allow only a single value input or not. Please review > condition "accessed-after-expiry" in ranger-servicedef-tag.json for uiHint > usage. > > > Diffs > ----- > > security-admin/src/main/webapp/scripts/utils/XAUtils.js a0b282e > security-admin/src/main/webapp/scripts/views/policies/PermissionList.js > 44134af > > Diff: https://reviews.apache.org/r/49009/diff/ > > > Testing > ------- > > **Verified :** > 1) For some components(like-tag) it allows only one value in field -- "policy > conditions-Accessed after expiry?Yes or No" > > 2) For some cmponents(like-Knox, Kafka and solr) it allows multiple values in > field-- "policy conditions-ip range" > > > Thanks, > > Mehul Parikh > >
