----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49079/#review139187 -----------------------------------------------------------
>> However, this does not return the user groups correctly for testing purposes Can you please add details of the tests that are affected by the current implementation? It will help determine if changes to plugin code are justified. Ideally, any such change should only be scoped to tests. - Madhan Neethiraj On June 22, 2016, 10:48 a.m., Colm O hEigeartaigh wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/49079/ > ----------------------------------------------------------- > > (Updated June 22, 2016, 10:48 a.m.) > > > Review request for ranger. > > > Bugs: RANGER-1051 > https://issues.apache.org/jira/browse/RANGER-1051 > > > Repository: ranger > > > Description > ------- > > Currently, in the HBase plugin, we get the user groups by querying the > HbaseUserUtils. However, this does not return the user groups correctly for > testing purposes, when creating users via UserGroupInformation. If > HBaseUserUtils does not return any group information, then we should fall > back to checking the user's UGI groups. > > > Diffs > ----- > > > hbase-agent/src/main/java/org/apache/ranger/authorization/hbase/AuthorizationSession.java > fdf1527 > > Diff: https://reviews.apache.org/r/49079/diff/ > > > Testing > ------- > > Tests done locally, I'll submit Ranger tests in due course. > > > Thanks, > > Colm O hEigeartaigh > >
