> On June 24, 2016, 6:17 a.m., Gautam Borad wrote: > > tagsync/scripts/updatetagadminpassword.py, line 123 > > <https://reviews.apache.org/r/49172/diff/1/?file=1428949#file1428949line123> > > > > If not intentional, the comma at the end might give syntax error on > > strict environments. Please check.
It is intentional to ensure that CR/NL is not printed after the message (for better useability). Is there any way which is more portable? Thanks! - Abhay ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49172/#review139347 ----------------------------------------------------------- On June 24, 2016, 4:51 p.m., Abhay Kulkarni wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/49172/ > ----------------------------------------------------------- > > (Updated June 24, 2016, 4:51 p.m.) > > > Review request for ranger and Madhan Neethiraj. > > > Bugs: RANGER-1059 > https://issues.apache.org/jira/browse/RANGER-1059 > > > Repository: ranger > > > Description > ------- > > updatetagadminpassword.py scripts should use names of users of > ranger-admin/atlas which are configured in ranger-tagsync-site.xml for > prompting for updates to password. > > > Diffs > ----- > > tagsync/scripts/updatetagadminpassword.py 0b1f2ca > > Diff: https://reviews.apache.org/r/49172/diff/ > > > Testing > ------- > > > Thanks, > > Abhay Kulkarni > >
