-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49743/
-----------------------------------------------------------

(Updated July 8, 2016, 4:05 a.m.)


Review request for ranger, Madhan Neethiraj and Velmurugan Periasamy.


Changes
-------

Addressed review comments


Bugs: RANGER-1079
    https://issues.apache.org/jira/browse/RANGER-1079


Repository: ranger


Description
-------

tag sync process, during startup, initializes tag sources only once and ignores 
those which failed initialization. This causes a tag source to be ignored even 
if its initialization failed due to a transient error. Tag sync needs to be 
made more robust by periodically attempting re-initialization of failed tag 
sources and recover from transient errors during initialization.


Diffs (updated)
-----

  tagsync/src/main/java/org/apache/ranger/tagsync/model/AbstractTagSource.java 
d46170a 
  tagsync/src/main/java/org/apache/ranger/tagsync/model/TagSource.java 5ef6c57 
  tagsync/src/main/java/org/apache/ranger/tagsync/process/TagSyncConfig.java 
c52e0d2 
  tagsync/src/main/java/org/apache/ranger/tagsync/process/TagSynchronizer.java 
b1b17cd 

Diff: https://reviews.apache.org/r/49743/diff/


Testing
-------

Tested in a single node cluster with tag source as 'Atlas' and with zookeeper 
stopped. Tag-source initialization kept failing until zookeeper was started. 
Then tag-synchronizer started receiving tag events from Atlas.


Thanks,

Abhay Kulkarni

Reply via email to