[
https://issues.apache.org/jira/browse/RANGER-1109?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15382110#comment-15382110
]
Velmurugan Periasamy edited comment on RANGER-1109 at 7/18/16 11:29 AM:
------------------------------------------------------------------------
Raised by Josh Elser
{quote}
*Re: copying NOTICE from your ASL bundlings: I did find
https://github.com/spring-projects/spring-security/blob/master/notice.txt
which, I believe, your NOTICE file should also be including. (ps this is from
your PasswordComparisonAuthenticator.java file from spring-security). Was this
an omission or am I looking at the wrong version of the spring-security
project from which you copied the file? * Did you intend for the .idea
directory to be included with your source-release? Some extraneous. * LICENSE
contains unnecessary ASLv2-licensed references. Remove them before the next
release (repeat of Joe) * Backbone.Marionette LICENSE entry omits Copyright
information (as the others have present) *
./security-admin/src/main/webapp/libs/bower/esprima/esprima.js is BSD licensed
but does not appear in LICENSE (best as I can tell) *
./security-admin/src/main/webapp/libs/bower/jquery-ui/css/jquery-ui.css is MIT
licensed an does not appear in LICENSE (best as I can tell) * Why does
hive-agent/derby.log exist? It looks like this is an artifact created during
testing (it doesn't exist in your source tree, and was created on my build).
You should move this into target/ and not distribute it with your
source-release. * Again, echo'ing Joe, I'm not sure what to say about
./security-admin/src/main/webapp/fonts. Are they OK to redistribute in this
binary form as a Category-B (what is the source form of a Font? Is this
something to worry about?). * Why don't the following have ASL headers? -
ugsync/ldapconfigchecktool/ldapconfigcheck/dependency-reduced-pom.xml -
./security-admin/src/main/webapp/robots.txt Some nit-picky
things/recommendations: * I would recommend going through your
apache-rat-plugin exclusions list and try to prune out as much as possible.
There are a few exclusions which gave me pause (but do contained licensed
files), e.g. '**/bin/**', '**/test/resources/**'. The rat-plugin should be
your friend. * The MIT License section of your LICENSE file has "MIT License"
on every line which seems unnecessary to me :)
{quote}
was (Author: vperiasamy):
Raised by Josh Elser
* Re: copying NOTICE from your ASL bundlings: I did find
https://github.com/spring-projects/spring-security/blob/master/notice.txt
which, I believe, your NOTICE file should also be including. (ps this is from
your PasswordComparisonAuthenticator.java file from spring-security). Was this
an omission or am I looking at the wrong version of the spring-security
project from which you copied the file? * Did you intend for the .idea
directory to be included with your source-release? Some extraneous. * LICENSE
contains unnecessary ASLv2-licensed references. Remove them before the next
release (repeat of Joe) * Backbone.Marionette LICENSE entry omits Copyright
information (as the others have present) *
./security-admin/src/main/webapp/libs/bower/esprima/esprima.js is BSD licensed
but does not appear in LICENSE (best as I can tell) *
./security-admin/src/main/webapp/libs/bower/jquery-ui/css/jquery-ui.css is MIT
licensed an does not appear in LICENSE (best as I can tell) * Why does
hive-agent/derby.log exist? It looks like this is an artifact created during
testing (it doesn't exist in your source tree, and was created on my build).
You should move this into target/ and not distribute it with your
source-release. * Again, echo'ing Joe, I'm not sure what to say about
./security-admin/src/main/webapp/fonts. Are they OK to redistribute in this
binary form as a Category-B (what is the source form of a Font? Is this
something to worry about?). * Why don't the following have ASL headers? -
ugsync/ldapconfigchecktool/ldapconfigcheck/dependency-reduced-pom.xml -
./security-admin/src/main/webapp/robots.txt Some nit-picky
things/recommendations: * I would recommend going through your
apache-rat-plugin exclusions list and try to prune out as much as possible.
There are a few exclusions which gave me pause (but do contained licensed
files), e.g. '**/bin/**', '**/test/resources/**'. The rat-plugin should be
your friend. * The MIT License section of your LICENSE file has "MIT License"
on every line which seems unnecessary to me :)
> Address IPMC feedback raised during Ranger 0.6.0 release
> --------------------------------------------------------
>
> Key: RANGER-1109
> URL: https://issues.apache.org/jira/browse/RANGER-1109
> Project: Ranger
> Issue Type: Bug
> Reporter: Velmurugan Periasamy
>
> Address suggestions raised during Ranger 0.6.0 IPMC vote.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
