----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50227/#review142939 -----------------------------------------------------------
Ship it! Ship It! - Velmurugan Periasamy On July 20, 2016, 10:07 a.m., Pradeep Agrawal wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/50227/ > ----------------------------------------------------------- > > (Updated July 20, 2016, 10:07 a.m.) > > > Review request for ranger, Ankita Sinha, Don Bosco Durai, Gautam Borad, Abhay > Kulkarni, Madhan Neethiraj, Mehul Parikh, Ramesh Mani, Selvamohan Neethiraj, > and Velmurugan Periasamy. > > > Bugs: RANGER-1111 > https://issues.apache.org/jira/browse/RANGER-1111 > > > Repository: ranger > > > Description > ------- > > **Problem Statement:** > Ranger admin installation logs print ranger admin user password when it > creates rangeradmin user. > > **Proposed solution:** > Before sending statement to print in logs ; Create User SQL Statements for > logs will be regenerated after masking password. > > > Diffs > ----- > > kms/scripts/db_setup.py 1484fa1 > kms/scripts/dba_script.py 99ca3cf > security-admin/scripts/dba_script.py 89df1ad > > Diff: https://reviews.apache.org/r/50227/diff/ > > > Testing > ------- > > **Case-1 : Ranger Admin installation :** > **Steps Performed (with patch) :** > 1. After mvn Build; untar the Ranger admin module and updated > install.properties for MySQL DB flavor. > 2. Called setup.sh to install Ranger. > > **Expected Behavior :** > Ranger installation should finish successfully and ranger db admin password > should not appear in installation logs and password value should be masked > with "********" characters. > > **Actual Behavior :** > Ranger installation finished successfully and ranger db admin password was > not appearing in installation logs. password value were masked with > "********" characters. > > ===================== > > **Case-2 : Ranger KMS installation :** > **Steps Performed (with patch) :** > 1. After mvn Build; untar the Ranger KMS module and updated > install.properties for MySQL DB flavor. > 2. Called setup.sh to install Ranger KMS. > > **Expected Behavior :** > Ranger KMS installation should finish successfully and Ranger KMS db admin > password should not appear in installation logs and password value should be > masked with "********" characters. > > **Actual Behavior :** > Ranger installation finished successfully and Ranger KMS db admin password > was not appearing in installation logs. password value were masked with > "********" characters. > > ===================== > Note: Patch is working as expected for Ranger Admin and Ranger KMS on all > supported DB Flavors. > > > Thanks, > > Pradeep Agrawal > >
