----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50471/#review143731 -----------------------------------------------------------
Ship it! Ship It! - Madhan Neethiraj On July 27, 2016, 10:59 a.m., Abhay Kulkarni wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/50471/ > ----------------------------------------------------------- > > (Updated July 27, 2016, 10:59 a.m.) > > > Review request for ranger and Madhan Neethiraj. > > > Bugs: RANGER-1125 > https://issues.apache.org/jira/browse/RANGER-1125 > > > Repository: ranger > > > Description > ------- > > Ranger Tagsync is updated to handle change notifications for deleted entities > - for example add/remove of tags for deleted entities. In such cases, Ranger > Tagsync ignores these notifications, so that tags associated with current > entities are not updated inadvertently. > > > Diffs > ----- > > > tagsync/src/main/java/org/apache/ranger/tagsync/source/atlas/AtlasEntityWithTraits.java > e6a4b36 > > tagsync/src/main/java/org/apache/ranger/tagsync/source/atlas/AtlasNotificationMapper.java > 793ac28 > > Diff: https://reviews.apache.org/r/50471/diff/ > > > Testing > ------- > > Dropped an existing table using beeline. Added tag to the soft-deleted table > in Atlas using REST API. Ensured that although the TRAIT_ADD notification was > received by tagsync for soft-deleted table, it did not create corresponding > service-resource and tag-resource association in Ranger. > > > Thanks, > > Abhay Kulkarni > >
