----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50464/#review143880 -----------------------------------------------------------
agents-audit/src/main/java/org/apache/ranger/audit/provider/AuditProviderFactory.java (line 70) <https://reviews.apache.org/r/50464/#comment209831> Consider adding 'volatile' here. agents-audit/src/main/java/org/apache/ranger/audit/provider/solr/SolrAuditProvider.java <https://reviews.apache.org/r/50464/#comment209832> - add 'volatile' in line #45 - consider using the pattern used in AuditProviderFactory.getInstance(). agents-audit/src/main/java/org/apache/ranger/audit/utils/InMemoryJAASConfiguration.java (line 151) <https://reviews.apache.org/r/50464/#comment209834> since in.close() is now handled in finally block, please remove this from catch block. - Madhan Neethiraj On July 26, 2016, 9:41 p.m., Ramesh Mani wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/50464/ > ----------------------------------------------------------- > > (Updated July 26, 2016, 9:41 p.m.) > > > Review request for ranger, Madhan Neethiraj and Velmurugan Periasamy. > > > Repository: ranger > > > Description > ------- > > RANGER-1124: Good coding practices in Ranger recommended by static code > analysis > > > Diffs > ----- > > > agents-audit/src/main/java/org/apache/ranger/audit/provider/AuditProviderFactory.java > e3e818c > > agents-audit/src/main/java/org/apache/ranger/audit/provider/solr/SolrAuditProvider.java > 9388914 > > agents-audit/src/main/java/org/apache/ranger/audit/utils/InMemoryJAASConfiguration.java > be9cdd3 > security-admin/src/main/java/org/apache/ranger/common/db/BaseDao.java > 13607d3 > > Diff: https://reviews.apache.org/r/50464/diff/ > > > Testing > ------- > > This patch contains the fixes for High priority issue. > > CID 150797 150725 150568 95608 > > Tested with local vm for any functionality breakage. > > > Thanks, > > Ramesh Mani > >
