----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50623/#review144250 -----------------------------------------------------------
Fix it, then Ship it! hdfs-agent/src/main/java/org/apache/ranger/services/hdfs/client/HdfsClient.java (line 90) <https://reviews.apache.org/r/50623/#comment210248> It looks the the scan flag was about 'fileStats.toString()' being not useful - as it is an array and only default Object.toString() will be printed. Instead, consider printing fileStats array length. hive-agent/src/main/java/org/apache/ranger/authorization/hive/authorizer/RangerHiveAuthorizer.java (line 683) <https://reviews.apache.org/r/50623/#comment210249> I think the scan flag was about maskTypeDef being null, which is not handled in line #684. Please review. - Madhan Neethiraj On July 30, 2016, 12:26 a.m., Ramesh Mani wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/50623/ > ----------------------------------------------------------- > > (Updated July 30, 2016, 12:26 a.m.) > > > Review request for ranger, Madhan Neethiraj and Velmurugan Periasamy. > > > Repository: ranger > > > Description > ------- > > RANGER-1124 : Good coding practices in Ranger recommended by static code > analysis - medium impact > > > Diffs > ----- > > > agents-audit/src/main/java/org/apache/ranger/audit/destination/SolrAuditDestination.java > 46f33a5 > agents-audit/src/main/java/org/apache/ranger/audit/provider/MiscUtil.java > 8ad4616 > > agents-audit/src/main/java/org/apache/ranger/audit/queue/AuditFileSpool.java > 17ddab9 > > hbase-agent/src/main/java/org/apache/ranger/services/hbase/client/HBaseClient.java > 65e7be6 > > hdfs-agent/src/main/java/org/apache/ranger/services/hdfs/client/HdfsClient.java > bc98d24 > > hive-agent/src/main/java/org/apache/ranger/authorization/hive/authorizer/RangerHiveAuthorizer.java > bfe1891 > > plugin-kafka/src/main/java/org/apache/ranger/authorization/kafka/authorizer/RangerKafkaAuthorizer.java > 1afedd5 > > plugin-solr/src/main/java/org/apache/ranger/authorization/solr/authorizer/RangerSolrAuthorizer.java > 9371eaa > > ranger-plugin-classloader/src/main/java/org/apache/ranger/plugin/classloader/RangerPluginClassLoaderUtil.java > ea18883 > > Diff: https://reviews.apache.org/r/50623/diff/ > > > Testing > ------- > > > Thanks, > > Ramesh Mani > >
