> On Aug. 1, 2016, 3:17 a.m., Don Bosco Durai wrote: > > agents-common/src/main/java/org/apache/ranger/plugin/audit/RangerDefaultAuditHandler.java, > > line 167 > > <https://reviews.apache.org/r/50649/diff/1/?file=1458869#file1458869line167> > > > > If something is wrong, the this will generate a lot of logs. You could > > use org.apache.ranger.audit.provider.MiscUtil.logErrorMessageByInterval() > > to limit the number of warn logs.
Thanks for your comments. I update the patch to use logErrorMessageByInterval() for trace. - Dongying ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50649/#review144300 ----------------------------------------------------------- On Aug. 2, 2016, 2:07 a.m., Dongying Jiao wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/50649/ > ----------------------------------------------------------- > > (Updated Aug. 2, 2016, 2:07 a.m.) > > > Review request for ranger. > > > Bugs: RANGER-1131 > https://issues.apache.org/jira/browse/RANGER-1131 > > > Repository: ranger > > > Description > ------- > > AuditHandler.log function returns true or false to indicate the audit log > result, but the caller doesn't handle this return value. So if the audit is > failed to log, we can't find any clue in the trace. > > > Diffs > ----- > > > agents-common/src/main/java/org/apache/ranger/plugin/audit/RangerDefaultAuditHandler.java > 60d3b0c > > Diff: https://reviews.apache.org/r/50649/diff/ > > > Testing > ------- > > Warn level trace is added to indicate audit logging failure. The trace can be > found in the component who has ranger plugin enabled. > Built clean and ran all unit tests passed. > > > Thanks, > > Dongying Jiao > >
