-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50624/#review144760
-----------------------------------------------------------




agents-audit/src/main/java/org/apache/ranger/audit/destination/HDFSAuditDestination.java
 (line 155)
<https://reviews.apache.org/r/50624/#comment210859>

    Earlier implementation (in AuditAsyncQueue.run()/
    AuditBatchQueue.run()/AuditFileSpool.run()/AuditSummaryQueue.run()) handles 
MiscUtil.getUGILoginUser() == null.
    
    Please review and update the changes introduced in this commit (in 
HDFSAuditDestination/SolrAuditDestination/SolrAuditProvider/KafkaAuditProvider) 
to handle this condition. Perhaps the following would work:
    
    UserGroupInformation doAsUser = MiscUtil.getUGILoginUser();
    if(doAsUser != null) {
      doAsUser.doAs(action);
    } else {
      action.run();
    }


- Madhan Neethiraj


On Aug. 4, 2016, 5:28 a.m., Ramesh Mani wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/50624/
> -----------------------------------------------------------
> 
> (Updated Aug. 4, 2016, 5:28 a.m.)
> 
> 
> Review request for ranger, Madhan Neethiraj, Selvamohan Neethiraj, and 
> Velmurugan Periasamy.
> 
> 
> Repository: ranger
> 
> 
> Description
> -------
> 
> RANGER-1136:
> Ranger audit to HDFS fails with TGT errors in Ranger HiveServer2 plugin when 
> UGI -TGT expires in audit thread
> 
> 
> Diffs
> -----
> 
>   
> agents-audit/src/main/java/org/apache/ranger/audit/destination/HDFSAuditDestination.java
>  9da97ed 
>   
> agents-audit/src/main/java/org/apache/ranger/audit/destination/SolrAuditDestination.java
>  46f33a5 
>   
> agents-audit/src/main/java/org/apache/ranger/audit/provider/kafka/KafkaAuditProvider.java
>  2c77b40 
>   
> agents-audit/src/main/java/org/apache/ranger/audit/provider/solr/SolrAuditProvider.java
>  9388914 
>   
> agents-audit/src/main/java/org/apache/ranger/audit/queue/AuditAsyncQueue.java 
> e7adef2 
>   
> agents-audit/src/main/java/org/apache/ranger/audit/queue/AuditBatchQueue.java 
> 5b56c96 
>   
> agents-audit/src/main/java/org/apache/ranger/audit/queue/AuditFileSpool.java 
> 17ddab9 
>   
> agents-audit/src/main/java/org/apache/ranger/audit/queue/AuditSummaryQueue.java
>  70c322d 
> 
> Diff: https://reviews.apache.org/r/50624/diff/
> 
> 
> Testing
> -------
> 
> Testing done in local vm
> 
> 
> Thanks,
> 
> Ramesh Mani
> 
>

Reply via email to