----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51050/#review145701 -----------------------------------------------------------
agents-common/src/main/java/org/apache/ranger/plugin/audit/RangerDefaultAuditHandler.java (line 45) <https://reviews.apache.org/r/51050/#comment212052> Consider initializing here with MiscUtil.generateUniqueId(), instead of NULL, to avoid having to check for null while generating each ID. agents-common/src/main/java/org/apache/ranger/plugin/audit/RangerDefaultAuditHandler.java (line 46) <https://reviews.apache.org/r/51050/#comment212048> Since 'counter' could be accessed/modified from multiple threads simultaneously, use type AtomicInteger/AtomicLong and call counter.getAndIncrement(), instead of "counter = counter + 1" agents-common/src/main/java/org/apache/ranger/plugin/audit/RangerDefaultAuditHandler.java (line 47) <https://reviews.apache.org/r/51050/#comment212053> 'serviceName' should not be necessary. Consider removing it. agents-common/src/main/java/org/apache/ranger/plugin/audit/RangerDefaultAuditHandler.java (line 252) <https://reviews.apache.org/r/51050/#comment212050> to avoid possible confusion between getUUID() and generateUUID(), consider renaming getUUID() to generateNextAuditEventId() agents-common/src/main/java/org/apache/ranger/plugin/audit/RangerDefaultAuditHandler.java (line 253) <https://reviews.apache.org/r/51050/#comment212051> synchronizing this method might impact performance. Consider the following alternate to avoid it: private String generateNextAuditEventId() { int nextId = counter.getAndIncrement(); if(nextId == Integer.MAX_VALUE) { // reset UUID and counter RangerDefaultAuditHandler.UUID = MiscUtil.generateUniqueId(); counter = new AtomicInteger(0); } String ret = RangerDefaultAuditHandler.UUID + "-" + Integer.toString(nextId); return ret; } agents-common/src/main/java/org/apache/ranger/plugin/audit/RangerDefaultAuditHandler.java (line 259) <https://reviews.apache.org/r/51050/#comment212049> adding serviceName to UUID may not be helpful. Consider removing it. agents-common/src/main/java/org/apache/ranger/plugin/audit/RangerDefaultAuditHandler.java (line 264) <https://reviews.apache.org/r/51050/#comment212054> Consider removing methods initialize_UUID/setUUID/generateUUID/getServiceName/setServiceName - Madhan Neethiraj On Aug. 12, 2016, 9:46 p.m., Ramesh Mani wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/51050/ > ----------------------------------------------------------- > > (Updated Aug. 12, 2016, 9:46 p.m.) > > > Review request for ranger, Madhan Neethiraj and Velmurugan Periasamy. > > > Repository: ranger > > > Description > ------- > > RANGER-1152: Improver performance of ranger audit login while audit event-id > creation > > > Diffs > ----- > > > agents-common/src/main/java/org/apache/ranger/plugin/audit/RangerDefaultAuditHandler.java > a6961c1 > > Diff: https://reviews.apache.org/r/51050/diff/ > > > Testing > ------- > > Tested in Local VM > > > Thanks, > > Ramesh Mani > >
