----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51473/#review147232 -----------------------------------------------------------
Fix it, then Ship it! agents-common/src/test/resources/policyengine/test_policyengine_tag_hive_filebased.json (line 270) <https://reviews.apache.org/r/51473/#comment214348> The context should not be specified as the file-based tag enricher reads tags from /policyengine/resourceTags.json resource. - Abhay Kulkarni On Aug. 29, 2016, 5:39 p.m., Madhan Neethiraj wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/51473/ > ----------------------------------------------------------- > > (Updated Aug. 29, 2016, 5:39 p.m.) > > > Review request for ranger, Alok Lal, Don Bosco Durai, Gautam Borad, Abhay > Kulkarni, Ramesh Mani, Selvamohan Neethiraj, Sailaja Polavarapu, and > Velmurugan Periasamy. > > > Bugs: RANGER-1162 > https://issues.apache.org/jira/browse/RANGER-1162 > > > Repository: ranger > > > Description > ------- > > Updated the logic to retrieve tags for a given resource by using trie, > similar to policy evaluation optimization done in RANGER-1161 > > > Diffs > ----- > > > agents-common/src/main/java/org/apache/ranger/plugin/contextenricher/RangerServiceResourceMatcher.java > 5c1ae64 > > agents-common/src/main/java/org/apache/ranger/plugin/contextenricher/RangerTagEnricher.java > c397ca1 > > agents-common/src/main/java/org/apache/ranger/plugin/policyengine/RangerPolicyEngineImpl.java > d0e8d62 > > agents-common/src/main/java/org/apache/ranger/plugin/policyengine/RangerPolicyRepository.java > d06aecd > > agents-common/src/main/java/org/apache/ranger/plugin/policyevaluator/RangerAbstractPolicyEvaluator.java > 8f45661 > > agents-common/src/main/java/org/apache/ranger/plugin/policyevaluator/RangerPolicyEvaluator.java > 23069cf > > agents-common/src/main/java/org/apache/ranger/plugin/policyresourcematcher/RangerDefaultPolicyResourceMatcher.java > 78589cd > > agents-common/src/main/java/org/apache/ranger/plugin/policyresourcematcher/RangerPolicyResourceEvaluator.java > PRE-CREATION > > agents-common/src/main/java/org/apache/ranger/plugin/policyresourcematcher/RangerPolicyResourceMatcher.java > 80da868 > > agents-common/src/main/java/org/apache/ranger/plugin/util/RangerResourceTrie.java > a5ffd1a > > agents-common/src/main/java/org/apache/ranger/plugin/util/ServiceDefUtil.java > eaf60b7 > > agents-common/src/test/java/org/apache/ranger/plugin/contextenricher/TestTagEnricher.java > PRE-CREATION > > agents-common/src/test/java/org/apache/ranger/plugin/policyengine/TestPolicyEngine.java > f825f40 > agents-common/src/test/resources/contextenricher/test_tagenricher_hive.json > PRE-CREATION > > agents-common/src/test/resources/policyengine/test_policyengine_tag_hive_filebased.json > 443ee53 > > Diff: https://reviews.apache.org/r/51473/diff/ > > > Testing > ------- > > Verified that all unit tests pass successfully > > > Thanks, > > Madhan Neethiraj > >
