-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50754/#review154692
-----------------------------------------------------------




agents-common/src/main/java/org/apache/ranger/plugin/model/RangerPluginServiceVersionInfo.java
 (line 41)
<https://reviews.apache.org/r/50754/#comment224364>

    I would suggest rename class "RangerPluginServiceVersionInfo" to 
"RangerPluginInfo" - and all related references like Service/filenames/etc.


- Madhan Neethiraj


On Nov. 3, 2016, 8:09 a.m., Abhay Kulkarni wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/50754/
> -----------------------------------------------------------
> 
> (Updated Nov. 3, 2016, 8:09 a.m.)
> 
> 
> Review request for ranger, Madhan Neethiraj and Ramesh Mani.
> 
> 
> Bugs: RANGER-1197
>     https://issues.apache.org/jira/browse/RANGER-1197
> 
> 
> Repository: ranger
> 
> 
> Description
> -------
> 
> Services like HBase can have a large number of nodes (master, region servers) 
> that run Ranger authorization plugins. In a large deployment having 100s of 
> such nodes, it might be challenging to find if all the nodes use the latest 
> authorization policies from Ranger Admin. An API to get status of the plugins 
> for a given service will be helpful to troubleshoot any issues. The API 
> should return the following details:
> plugin hostname
> plugin ip-address
> policyVersion in use
> time the policies were downloaded
> time the policies become effective
> tagVersion in use
> time the tags were downloaded
> time the tags become effective
> 
> 
> Diffs
> -----
> 
>   
> agents-common/src/main/java/org/apache/ranger/admin/client/RangerAdminClient.java
>  5ae9854 
>   
> agents-common/src/main/java/org/apache/ranger/admin/client/RangerAdminRESTClient.java
>  6ec44c4 
>   
> agents-common/src/main/java/org/apache/ranger/plugin/contextenricher/RangerAdminTagRetriever.java
>  7c5b378 
>   
> agents-common/src/main/java/org/apache/ranger/plugin/contextenricher/RangerFileBasedTagRetriever.java
>  db4c6e4 
>   
> agents-common/src/main/java/org/apache/ranger/plugin/contextenricher/RangerTagEnricher.java
>  1a6e1b2 
>   
> agents-common/src/main/java/org/apache/ranger/plugin/contextenricher/RangerTagFileStoreRetriever.java
>  1ee00d3 
>   
> agents-common/src/main/java/org/apache/ranger/plugin/contextenricher/RangerTagRetriever.java
>  3ec1754 
>   
> agents-common/src/main/java/org/apache/ranger/plugin/model/RangerPluginServiceVersionInfo.java
>  PRE-CREATION 
>   
> agents-common/src/main/java/org/apache/ranger/plugin/util/PolicyRefresher.java
>  014e866 
>   
> agents-common/src/main/java/org/apache/ranger/plugin/util/RangerRESTUtils.java
>  ed674ee 
>   agents-common/src/main/java/org/apache/ranger/plugin/util/SearchFilter.java 
> 49a48cd 
>   
> hbase-agent/src/test/java/org/apache/ranger/authorization/hbase/RangerAdminClientImpl.java
>  3269fbb 
>   
> hdfs-agent/src/test/java/org/apache/ranger/services/hdfs/RangerAdminClientImpl.java
>  5c612e9 
>   
> hive-agent/src/test/java/org/apache/ranger/services/hive/RangerAdminClientImpl.java
>  43770c2 
>   
> knox-agent/src/main/java/org/apache/ranger/admin/client/RangerAdminJersey2RESTClient.java
>  aeff332 
>   
> plugin-kafka/src/test/java/org/apache/ranger/authorization/kafka/authorizer/RangerAdminClientImpl.java
>  c08a6df 
>   
> plugin-kms/src/test/java/org/apache/ranger/authorization/kms/authorizer/RangerAdminClientImpl.java
>  e889447 
>   
> security-admin/db/mysql/patches/025-create-schema-for-plugin-service-version-tracking.sql
>  PRE-CREATION 
>   
> security-admin/db/postgres/patches/025-create-schema-for-plugin-service-version-tracking.sql
>  PRE-CREATION 
>   security-admin/src/main/java/org/apache/ranger/biz/AssetMgr.java 931356e 
>   security-admin/src/main/java/org/apache/ranger/common/RangerSearchUtil.java 
> 2d049a4 
>   
> security-admin/src/main/java/org/apache/ranger/common/db/RangerTransactionSynchronizationAdapter.java
>  PRE-CREATION 
>   security-admin/src/main/java/org/apache/ranger/db/RangerDaoManagerBase.java 
> 6cd5c9f 
>   
> security-admin/src/main/java/org/apache/ranger/db/XXPluginServiceVersionInfoDao.java
>  PRE-CREATION 
>   
> security-admin/src/main/java/org/apache/ranger/entity/XXPluginServiceVersionInfo.java
>  PRE-CREATION 
>   security-admin/src/main/java/org/apache/ranger/rest/AssetREST.java 3d2997b 
>   security-admin/src/main/java/org/apache/ranger/rest/PublicAPIsv2.java 
> e2a6435 
>   security-admin/src/main/java/org/apache/ranger/rest/ServiceREST.java 
> 19fea65 
>   security-admin/src/main/java/org/apache/ranger/rest/TagREST.java b76c308 
>   security-admin/src/main/java/org/apache/ranger/rest/TagRESTConstants.java 
> 7f836bc 
>   
> security-admin/src/main/java/org/apache/ranger/security/context/RangerAPIList.java
>  6466712 
>   
> security-admin/src/main/java/org/apache/ranger/security/context/RangerAPIMapping.java
>  28b0a37 
>   
> security-admin/src/main/java/org/apache/ranger/service/RangerPluginActivityLogger.java
>  PRE-CREATION 
>   
> security-admin/src/main/java/org/apache/ranger/service/RangerPluginServiceVersionInfoService.java
>  PRE-CREATION 
>   
> security-admin/src/main/java/org/apache/ranger/service/RangerTransactionService.java
>  PRE-CREATION 
>   
> security-admin/src/main/java/org/apache/ranger/view/RangerPluginServiceVersionInfoList.java
>  PRE-CREATION 
>   security-admin/src/main/resources/META-INF/jpa_named_queries.xml a94b9a0 
>   security-admin/src/main/resources/META-INF/persistence.xml b0f764a 
>   security-admin/src/test/java/org/apache/ranger/rest/TestServiceREST.java 
> e951549 
>   security-admin/src/test/java/org/apache/ranger/rest/TestTagREST.java 
> fabd384 
>   
> storm-agent/src/test/java/org/apache/ranger/authorization/storm/RangerAdminClientImpl.java
>  e327435 
> 
> Diff: https://reviews.apache.org/r/50754/diff/
> 
> 
> Testing
> -------
> 
> Tested with a local VM with hdfs and hive components.
> 
> 
> Thanks,
> 
> Abhay Kulkarni
> 
>

Reply via email to