----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53259/#review154854 -----------------------------------------------------------
Ship it! Ship It! - Don Bosco Durai On Oct. 28, 2016, 10:33 a.m., Qiang Zhang wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/53259/ > ----------------------------------------------------------- > > (Updated Oct. 28, 2016, 10:33 a.m.) > > > Review request for ranger, Don Bosco Durai and Velmurugan Periasamy. > > > Bugs: RANGER-1187 > https://issues.apache.org/jira/browse/RANGER-1187 > > > Repository: ranger > > > Description > ------- > > My solution to fix bug https://issues.apache.org/jira/browse/RANGER-1187: > In main method of C file pamCredValidator.c, pam_end() is not called before > exit when authentication failed. > Please review my code, I would like to know whether there is any problem. > I expect your reply very much, thanks. > > > Diffs > ----- > > unixauthpam/src/main/c/pamCredValidator.c ab19080 > > Diff: https://reviews.apache.org/r/53259/diff/ > > > Testing > ------- > > The issue was identified through code analysis, rather than through any known > ill effect. > I just complie and deloy it, so who can provide test case would be very > helpful. > > > Thanks, > > Qiang Zhang > >
