-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53527/
-----------------------------------------------------------

Review request for ranger, Ankita Sinha, Don Bosco Durai, Gautam Borad, Abhay 
Kulkarni, Madhan Neethiraj, Mehul Parikh, Ramesh Mani, Selvamohan Neethiraj, 
and Velmurugan Periasamy.


Bugs: RANGER-1206
    https://issues.apache.org/jira/browse/RANGER-1206


Repository: ranger


Description
-------

**Problem Statement :** If DB or Java patches are already applied then upgrade 
or install script again checks whether patches are already applied or not. If 
patches are already applied for specific ranger version then re-install or 
upgrade process should skip the applied patches and apply only new patches.

**Proposed Solution :**

After execution of db and java patches, script shall insert an entry into 
x_db_version_h table with version='DB_PATCHES' and version='JAVA_PATCHES' 
repectively. inst_by field shall contain ranger version while updated_by field 
shall contain client host details.

This way whenever db setup script will be called ; script shall check for 
version='DB_PATCHES' entry before executing any db patch for specfic ranger 
version; if it exist then none of db patches will be executed and installation 
script will not check whether all db patches are applied or not.

Similarly whenever java patch installation script will be called ; script shall 
check for version='JAVA_PATCHES' entry before executing any java patch for 
specfic ranger version; if it exist then none of java patches will be executed 
and installation script will not check whether all java patches are applied or 
not.


Diffs
-----

  security-admin/scripts/db_setup.py c1efd4a 
  security-admin/scripts/setup.sh 40c8584 

Diff: https://reviews.apache.org/r/53527/diff/


Testing
-------

**Case-1 : Ranger Admin installation : **
Steps Performed (with patch) :
1. After mvn Build; untar the Ranger admin module and updated 
install.properties for MySQL DB flavor.
2. Called setup.sh to install Ranger.

**Expected Behavior : **
Ranger installation should finish successfully and after execution of db 
patches, in x_db_version_h table there should be an entry with 
version='DB_PATCHES' for current ranger version.
Similary after execution of java patches, in x_db_version_h table there should 
be an entry with version='JAVA_PATCHES' for current ranger version.

Also if setup.sh script is executed again then db and java patches check should 
be skipped as flag will be there as per above description.

**Actual Behavior : ** Ranger installation finished successfully and it was 
observed that x_db_version_h table has below given two entries :
id | version        | inst_at             | inst_by            | updated_at     
     | updated_by         | active
30 | DB_PATCHES     | 2016-11-07 03:42:37 | Ranger 0.6.0       | 2016-11-07 
03:42:37 | node-1.example.com | Y
31 | JAVA_PATCHES   | 2016-11-07 03:42:42 | Ranger 0.6.0       | 2016-11-07 
03:42:42 | node-1.example.com | Y

During second execution of setup.sh none of the db or java patches status was 
checked or were attempted to apply.


Thanks,

Pradeep Agrawal

Reply via email to