----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53469/#review155260 -----------------------------------------------------------
Read-write lock is implemented for both of the methods (getKeyVersion() and getMetadata()) in implemented Provider i.e RangerKeyStoreProvider.java,so no much need of read-write lock in KeyAuthorizationKeyProvider.java. Please let us know then too if we need to have this committed. - Ankita Sinha On Nov. 4, 2016, 8:57 a.m., Qiang Zhang wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/53469/ > ----------------------------------------------------------- > > (Updated Nov. 4, 2016, 8:57 a.m.) > > > Review request for ranger, Don Bosco Durai, Ramesh Mani, and Velmurugan > Periasamy. > > > Bugs: RANGER-1205 > https://issues.apache.org/jira/browse/RANGER-1205 > > > Repository: ranger > > > Description > ------- > > Some methods lack Read-write lock operation of the > KeyAuthorizationKeyProvider.java in ranger kms. > > Methods: > 1.public KeyVersion getKeyVersion(String versionName) > 2.public Metadata getMetadata(String name) > > > Diffs > ----- > > > kms/src/main/java/org/apache/hadoop/crypto/key/kms/server/KeyAuthorizationKeyProvider.java > bd35a6b > > Diff: https://reviews.apache.org/r/53469/diff/ > > > Testing > ------- > > > Thanks, > > Qiang Zhang > >
