[ https://issues.apache.org/jira/browse/RANGER-696?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15658556#comment-15658556 ]
Sailaja Polavarapu commented on RANGER-696: ------------------------------------------- [~Wancy], I reviewed the changes. Just thinking out loud on couple of scenarios how they will be handled: 1. I couldn't find the condition where we check if the new username is already existing before we update. Shouldn't we check this condition? We don't want two users having same username right? 2. Since the code can be used to change any user's username, say user1's name is changed to abc1 and the password is also updated accordingly. Say as part of Ldap/AD usersync, we have a new user with same username ('abc1'), with the existing usersync /ranger interaction code, isn't there is a possibility that we accidentally update a wrong user with information from AD as we use findByUserName() for retrieving the user info from the database? 3. One UI scenario - if some policies are configured for the user, then the ranger admin will show the old username until refreshed. > Option to use custom "admin" username > ------------------------------------- > > Key: RANGER-696 > URL: https://issues.apache.org/jira/browse/RANGER-696 > Project: Ranger > Issue Type: Improvement > Components: admin > Affects Versions: 0.5.1 > Reporter: Don Bosco Durai > Assignee: Shi Wang > Fix For: 0.7.0 > > Attachments: 0001-RANGER-696-Option-to-use-custom-admin-username.patch > > > It would be good to allow customization of Admin username other than "admin". > The reason being, in some environment, there might be another user called > "admin" and that might conflict with Ranger "admin" user. > Giving an option to set another name or exclude external synchronization of > user with "admin" will be useful. -- This message was sent by Atlassian JIRA (v6.3.4#6332)