----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53924/#review156464 -----------------------------------------------------------
Fix it, then Ship it! agents-common/src/main/java/org/apache/ranger/plugin/policyresourcematcher/RangerDefaultPolicyResourceMatcher.java (line 487) <https://reviews.apache.org/r/53924/#comment226650> It might be efficient to first check if firstValidResourceDefHierarchy matches the resource, before checking for all possible hierarchies. Please review. - Madhan Neethiraj On Nov. 19, 2016, 6:17 a.m., Abhay Kulkarni wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/53924/ > ----------------------------------------------------------- > > (Updated Nov. 19, 2016, 6:17 a.m.) > > > Review request for ranger and Madhan Neethiraj. > > > Bugs: RANGER-1222 > https://issues.apache.org/jira/browse/RANGER-1222 > > > Repository: ranger > > > Description > ------- > > Updated PolicyResource Matching algorithm to handle service-definitions which > support multiple valid resource hierarchies. > > > Diffs > ----- > > > agents-common/src/main/java/org/apache/ranger/plugin/policyresourcematcher/RangerDefaultPolicyResourceMatcher.java > 5e2fa74 > > agents-common/src/test/resources/resourcematcher/test_defaultpolicyresourcematcher.json > 71995dc > > Diff: https://reviews.apache.org/r/53924/diff/ > > > Testing > ------- > > Compiled and ran unit tests with both JDK 1.7 and JDK 1.8 > > > Thanks, > > Abhay Kulkarni > >
