----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54044/#review156790 -----------------------------------------------------------
Fix it, then Ship it! agents-common/src/main/java/org/apache/ranger/plugin/store/AbstractServiceStore.java (line 114) <https://reviews.apache.org/r/54044/#comment227081> "final" may not be useful here - unless the intention is to prevent override from derived classes. Please review and remove if that is not the intent. Same comment for postUpdate() and postDelete() as well. - Madhan Neethiraj On Nov. 23, 2016, 8:40 p.m., Abhay Kulkarni wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/54044/ > ----------------------------------------------------------- > > (Updated Nov. 23, 2016, 8:40 p.m.) > > > Review request for ranger and Madhan Neethiraj. > > > Bugs: RANGER-1228 > https://issues.apache.org/jira/browse/RANGER-1228 > > > Repository: ranger > > > Description > ------- > > File and REST stores, while useful during earlier iterations of Ranger > development, are hard to maintain and not required any more. > > > Diffs > ----- > > > agents-common/src/main/java/org/apache/ranger/plugin/contextenricher/RangerTagFileStoreRetriever.java > 85cf420 > > agents-common/src/main/java/org/apache/ranger/plugin/store/AbstractServiceStore.java > ebb4b78 > > agents-common/src/main/java/org/apache/ranger/plugin/store/AbstractTagStore.java > ebf7d6e > > agents-common/src/main/java/org/apache/ranger/plugin/store/ServiceStore.java > b30f2c8 > > agents-common/src/main/java/org/apache/ranger/plugin/store/file/ServiceFileStore.java > b2e06f9 > > agents-common/src/main/java/org/apache/ranger/plugin/store/file/TagFileStore.java > 780d379 > > agents-common/src/main/java/org/apache/ranger/plugin/store/rest/ServiceRESTStore.java > 8f01934 > > agents-common/src/test/java/org/apache/ranger/plugin/store/TestServiceStore.java > 90e97b7 > > agents-common/src/test/java/org/apache/ranger/plugin/store/TestTagStore.java > d8d61d4 > security-admin/src/main/java/org/apache/ranger/biz/ServiceDBStore.java > 3841785 > > Diff: https://reviews.apache.org/r/54044/diff/ > > > Testing > ------- > > Ran unit tests successfully. > > > Thanks, > > Abhay Kulkarni > >
