----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54692/#review159220 -----------------------------------------------------------
Fix it, then Ship it! security-admin/src/main/java/org/apache/ranger/db/XXServiceDao.java (line 84) <https://reviews.apache.org/r/54692/#comment230160> Consider renaming: findIfAssociatedWithTagService ==> findAssociatedTagService - for both method and the query-name - Madhan Neethiraj On Dec. 13, 2016, 3:19 a.m., Abhay Kulkarni wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/54692/ > ----------------------------------------------------------- > > (Updated Dec. 13, 2016, 3:19 a.m.) > > > Review request for ranger, Madhan Neethiraj and Velmurugan Periasamy. > > > Bugs: RANGER-1251 > https://issues.apache.org/jira/browse/RANGER-1251 > > > Repository: ranger > > > Description > ------- > > If a service that has associated tag-service is modified to remove it's > tag-service association, Ranger Plugin status GUI (incorrectly) continues to > display tag-related timestamps. > > > Diffs > ----- > > security-admin/src/main/java/org/apache/ranger/biz/AssetMgr.java 479099d > security-admin/src/main/java/org/apache/ranger/db/XXServiceDao.java 240345f > > security-admin/src/main/java/org/apache/ranger/service/RangerPluginInfoService.java > b496b86 > security-admin/src/main/resources/META-INF/jpa_named_queries.xml ac34b07 > > Diff: https://reviews.apache.org/r/54692/diff/ > > > Testing > ------- > > Tested with local VM. > > > Thanks, > > Abhay Kulkarni > >
