----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54905/#review159979 -----------------------------------------------------------
plugin-kafka/src/test/java/org/apache/ranger/authorization/kafka/authorizer/KafkaRangerAuthorizerTest.java (line 21) <https://reviews.apache.org/r/54905/#comment231009> Colm - I am not able to apply this patch. Can you please check? ``` $ git pull Already up-to-date. $ git status On branch master Your branch is up-to-date with 'origin/master'. nothing to commit, working directory clean $ git apply --check -v < ~/Downloads/patches/ranger/0001-RANGER-1273-Add-tests-for-Kafka-SASL_SSL-PLAIN.patch.old Checking patch plugin-kafka/pom.xml... Checking patch plugin-kafka/src/test/java/org/apache/ranger/authorization/kafka/authorizer/KafkaRangerAuthorizerSASLSSLTest.java... Checking patch plugin-kafka/src/test/java/org/apache/ranger/authorization/kafka/authorizer/KafkaRangerAuthorizerTest.java... error: while searching for: import java.io.FileOutputStream; import java.math.BigInteger; import java.net.ServerSocket; import java.security.KeyPair; import java.security.KeyPairGenerator; import java.security.KeyStore; import java.security.SecureRandom; import java.security.cert.Certificate; import java.security.cert.X509Certificate; import java.util.Arrays; import java.util.Date; import java.util.Properties; import java.util.concurrent.Future; error: patch failed: plugin-kafka/src/test/java/org/apache/ranger/authorization/kafka/authorizer/KafkaRangerAuthorizerTest.java:21 error: plugin-kafka/src/test/java/org/apache/ranger/authorization/kafka/authorizer/KafkaRangerAuthorizerTest.java: patch does not apply Checking patch plugin-kafka/src/test/java/org/apache/ranger/authorization/kafka/authorizer/KafkaTestUtils.java... Checking patch plugin-kafka/src/test/resources/kafka_plain.jaas... Checking patch pom.xml... ``` - Velmurugan Periasamy On Dec. 20, 2016, 5:11 p.m., Colm O hEigeartaigh wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/54905/ > ----------------------------------------------------------- > > (Updated Dec. 20, 2016, 5:11 p.m.) > > > Review request for ranger. > > > Bugs: RANGER-1273 > https://issues.apache.org/jira/browse/RANGER-1273 > > > Repository: ranger > > > Description > ------- > > Currently we have tests in Ranger for authorization for Kafka using SSL. We > should also add tests for authorization for SASL_SSL + PLAIN. > > > Diffs > ----- > > plugin-kafka/pom.xml 05aace2 > > plugin-kafka/src/test/java/org/apache/ranger/authorization/kafka/authorizer/KafkaRangerAuthorizerSASLSSLTest.java > PRE-CREATION > > plugin-kafka/src/test/java/org/apache/ranger/authorization/kafka/authorizer/KafkaRangerAuthorizerTest.java > 1039b57 > > plugin-kafka/src/test/java/org/apache/ranger/authorization/kafka/authorizer/KafkaTestUtils.java > PRE-CREATION > plugin-kafka/src/test/resources/kafka_plain.jaas PRE-CREATION > pom.xml 13e5da8 > > Diff: https://reviews.apache.org/r/54905/diff/ > > > Testing > ------- > > > Thanks, > > Colm O hEigeartaigh > >
