[ 
https://issues.apache.org/jira/browse/RANGER-1284?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15793894#comment-15793894
 ] 

Qiang Zhang commented on RANGER-1284:
-------------------------------------

Ok. Thanks. I have closed the review board request.

> Comment lines have not been filtered out when the populate_global_dict 
> function parsed install.properties in security-admin/scripts/db_setup.py. 
> -------------------------------------------------------------------------------------------------------------------------------------------------
>
>                 Key: RANGER-1284
>                 URL: https://issues.apache.org/jira/browse/RANGER-1284
>             Project: Ranger
>          Issue Type: Bug
>          Components: admin
>    Affects Versions: 0.7.0
>            Reporter: Qiang Zhang
>            Assignee: Qiang Zhang
>              Labels: patch
>         Attachments: 
> 0001-RANGER-1284-Comment-lines-have-not-been-filtered-out.patch
>
>
> Comment lines have not been filtered out when the populate_global_dict 
> function parsed install.properties in security-admin/scripts/db_setup.py. So 
> if we use '#' to comment a line and it includes '=', the comment will not 
> work. On the left of the '=', it will be parsed as a key and the right will 
> be parsed as a value. As a result, there are two problems as follows:
> 1. There are invalid attribute values in globalDict variable.
> 2. Invalid parsing will degrade the performance of program. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to