----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54886/#review160461 -----------------------------------------------------------
plugin-atlas/src/main/java/org/apache/ranger/services/atlas/client/AtlasClient.java (line 250) <https://reviews.apache.org/r/54886/#comment231619> AtlasQname and existingQueueName, you should name the variable appropriately. AtlasTermName should be right one. plugin-atlas/src/main/java/org/apache/ranger/services/atlas/client/AtlasResourceMgr.java (line 78) <https://reviews.apache.org/r/54886/#comment231618> yarnQueueName? yarnQueueList? Looks like cut and past error. correct all of it occurance - Ramesh Mani On Jan. 4, 2017, 1:41 a.m., Qiang Zhang wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/54886/ > ----------------------------------------------------------- > > (Updated Jan. 4, 2017, 1:41 a.m.) > > > Review request for ranger, Ankita Sinha, Don Bosco Durai, Gautam Borad, Abhay > Kulkarni, Madhan Neethiraj, Pradeep Agrawal, Ramesh Mani, Selvamohan > Neethiraj, and Velmurugan Periasamy. > > > Bugs: RANGER-1271 > https://issues.apache.org/jira/browse/RANGER-1271 > > > Repository: ranger > > > Description > ------- > > RANGER-ATLAS testConnection feature > > > Diffs > ----- > > > plugin-atlas/src/main/java/org/apache/ranger/services/atlas/RangerServiceAtlas.java > cb5a7eb > > plugin-atlas/src/main/java/org/apache/ranger/services/atlas/client/AtlasClient.java > PRE-CREATION > > plugin-atlas/src/main/java/org/apache/ranger/services/atlas/client/AtlasConnectionMgr.java > PRE-CREATION > > plugin-atlas/src/main/java/org/apache/ranger/services/atlas/client/AtlasResourceMgr.java > PRE-CREATION > src/main/assembly/admin-web.xml b06cdec > > Diff: https://reviews.apache.org/r/54886/diff/ > > > Testing > ------- > > This feature is for connect Ranger and Atlas. We through the following steps > to ensure the quality of the patch: > 1. Cloned latest ranger code. > 2. Checked our new code and build new version using jenkins. > 3. Build functional verification environment in Centos 6.5. > 4. Tested our patch strictly. And using web client to verify new feature > successfully. > 5. Edit src/main/assembly/admin-web.xml add atlas moduleSet > 6. Build and update patch for RANGER-1271. > > > Thanks, > > Qiang Zhang > >
