-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55166/
-----------------------------------------------------------
Review request for ranger, Don Bosco Durai, Madhan Neethiraj, Ramesh Mani,
Selvamohan Neethiraj, and Velmurugan Periasamy.
Bugs: RANGER-1290
https://issues.apache.org/jira/browse/RANGER-1290
Repository: ranger
Description
-------
Comment lines have not been filtered out when the populate_global_dict function
parsed install.properties in security-admin/scripts/dba_script.py. So if we use
'#' to comment a line and it includes '=', the comment will not work. On the
left of the '=', it will be parsed as a key and the right will be parsed as a
value. As a result, there are two problems as follows:
1. There are invalid attribute values in globalDict variable.
2. Invalid parsing will degrade the performance of program.
Diffs
-----
security-admin/scripts/dba_script.py 1b29c75
Diff: https://reviews.apache.org/r/55166/diff/
Testing
-------
Thanks,
Qiang Zhang