-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55128/
-----------------------------------------------------------
(Updated 一月 6, 2017, 12:43 a.m.)
Review request for ranger, Ankita Sinha, Don Bosco Durai, Gautam Borad, Madhan
Neethiraj, Ramesh Mani, Selvamohan Neethiraj, and Velmurugan Periasamy.
Bugs: RANGER-1287
https://issues.apache.org/jira/browse/RANGER-1287
Repository: ranger
Description (updated)
-------
#Solution:
1.The following code is repeated twice, remove one of them.
```java
valve.setRotatable(true);
```
2.The following code is repeated three times, removed by refactored to a method
startServer(final Tomcat server).
```java
try{
server.start();
server.getServer().await();
shutdownServer();
}catch (LifecycleException e) {
LOG.severe("Tomcat Server failed to start:" + e.toString());
e.printStackTrace();
}catch (Exception e) {
LOG.severe("Tomcat Server failed to start:" + e.toString());
e.printStackTrace();
}
```
Diffs
-----
embeddedwebserver/src/main/java/org/apache/ranger/server/tomcat/EmbeddedServer.java
7ebba8a
Diff: https://reviews.apache.org/r/55128/diff/
Testing
-------
#Test Result:
1.Start Ranger-Admin success, and Ranger-Admin is not in security mode;
2.Start Ranger-Admin success, and Ranger-Admin is in security mode with
Kerberos Authentication;
3.Find access_log.2017-01-03.15.log generated in dircetory
ranger-<version>-admin/ews/logs.
Thanks,
Qiang Zhang
