[
https://issues.apache.org/jira/browse/RANGER-1290?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15804045#comment-15804045
]
Qiang Zhang commented on RANGER-1290:
-------------------------------------
I find the issue in the security-admin/scripts/dba_script.py when reviewing
code. RANGER-1290 and RANGER-1284 belong to different files and in different
business logics. I forget to check if there is same problem in
security-admin/scripts/dba_script.py when I create RANGER-1284.
> Comment lines have not been filtered out when the populate_global_dict
> function parsed install.properties in security-admin/scripts/dba_script.py.
> ---------------------------------------------------------------------------------------------------------------------------------------------------
>
> Key: RANGER-1290
> URL: https://issues.apache.org/jira/browse/RANGER-1290
> Project: Ranger
> Issue Type: Bug
> Components: admin
> Reporter: Qiang Zhang
> Assignee: Qiang Zhang
> Priority: Minor
> Labels: patch
> Attachments:
> 0001-RANGER-1290-Comment-lines-have-not-been-filtered-out.patch
>
>
> Comment lines have not been filtered out when the populate_global_dict
> function parsed install.properties in security-admin/scripts/dba_script.py.
> So if we use '#' to comment a line and it includes '=', the comment will not
> work. On the left of the '=', it will be parsed as a key and the right will
> be parsed as a value. As a result, there are two problems as follows:
> 1. There are invalid attribute values in globalDict variable.
> 2. Invalid parsing will degrade the performance of program.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
