----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55450/#review161890 -----------------------------------------------------------
Ship it! Ship It! - Velmurugan Periasamy On Jan. 16, 2017, 10:56 a.m., Mehul Parikh wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/55450/ > ----------------------------------------------------------- > > (Updated Jan. 16, 2017, 10:56 a.m.) > > > Review request for ranger, Gautam Borad, Madhan Neethiraj, Pradeep Agrawal, > and Velmurugan Periasamy. > > > Bugs: RANGER-1305 > https://issues.apache.org/jira/browse/RANGER-1305 > > > Repository: ranger > > > Description > ------- > > When a service-def does not have any configuration, service create/edit form > in Ranger Admin UI does not show ‘Add New Configurations’ option. > > > Diffs > ----- > > security-admin/src/main/webapp/scripts/views/policies/RangerPolicyForm.js > 317c6ee > security-admin/src/main/webapp/scripts/views/service/ServiceCreate.js > c82f0af > security-admin/src/main/webapp/scripts/views/service/ServiceForm.js c731cea > security-admin/src/main/webapp/templates/service/ServiceForm_tmpl.html > a6f5ae6 > > Diff: https://reviews.apache.org/r/55450/diff/ > > > Testing > ------- > > Verified : > 1) Service CRUD without and with configs > 2) Test connection for simple as well as kerboers enabled env :: for sercice > created from empty config set and then later on by adding configs from UI. > 3) Policy enforcement from newly created service -- for servicedef which > originally had empty config sets. > > > Thanks, > > Mehul Parikh > >
