----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55151/#review162007 -----------------------------------------------------------
security-admin/src/main/java/org/apache/ranger/biz/ServiceDBStore.java (line 2699) <https://reviews.apache.org/r/55151/#comment233274> Given that this property is used in RangerTagDBRetriever as well, consider using a constant, instead of a hardcoded string in both places. security-admin/src/main/java/org/apache/ranger/biz/ServiceDBStore.java (line 2747) <https://reviews.apache.org/r/55151/#comment233270> if filterForServicePlugin==false, would tag version ever get updated? Please review. security-admin/src/main/java/org/apache/ranger/biz/ServiceDBStore.java (line 2757) <https://reviews.apache.org/r/55151/#comment233272> Same comment as in line #2757. - Madhan Neethiraj On Jan. 3, 2017, 9:37 p.m., Abhay Kulkarni wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/55151/ > ----------------------------------------------------------- > > (Updated Jan. 3, 2017, 9:37 p.m.) > > > Review request for ranger and Madhan Neethiraj. > > > Bugs: RANGER-1199 > https://issues.apache.org/jira/browse/RANGER-1199 > > > Repository: ranger > > > Description > ------- > > A Ranger configuration variable 'ranger.filter.tags.for.service.plugin' is > added with default value of 'true'. If 'true'; only tags that appear in > active tag-policy are downloaded to component; else this optimization is not > performed. > > > Diffs > ----- > > > security-admin/src/main/java/org/apache/ranger/biz/RangerTagDBRetriever.java > 04c27a7 > security-admin/src/main/java/org/apache/ranger/biz/ServiceDBStore.java > dfe927f > security-admin/src/main/java/org/apache/ranger/db/XXServiceResourceDao.java > ef90a45 > > security-admin/src/main/java/org/apache/ranger/db/XXServiceResourceElementDao.java > 4f958ea > > security-admin/src/main/java/org/apache/ranger/db/XXServiceResourceElementValueDao.java > e780bc1 > security-admin/src/main/java/org/apache/ranger/db/XXTagAttributeDao.java > a5b7fac > > Diff: https://reviews.apache.org/r/55151/diff/ > > > Testing > ------- > > Tested with local VM. > > > Thanks, > > Abhay Kulkarni > >
