[GitHub] [incubator-ratis] runzhiwang opened a new pull request #163: RATIS-1018. Fix Failed UT: testGroupInfo

Tue, 04 Aug 2020 02:22:46 -0700 


runzhiwang opened a new pull request #163:
URL: https://github.com/apache/incubator-ratis/pull/163


   ## What changes were proposed in this pull request?
   
   remove following assert
   ```
   if (RaftPeerId.valueOf(i.getServer().getId()).equals(killedFollower)) {
      Assert.assertTrue(i.getCommitIndex() <= maxCommit);
   }
   ```
   
   As the image shows, `killedFollower` is s0, after client receive 
RaftClientReply, s0 can still increase commit index if it receive metadata 
entry, then the commit index of s0 maybe greater than the max index in 
RaftClientReply.
   
   
![image](https://user-images.githubusercontent.com/51938049/89276864-b8045c80-d676-11ea-944b-4f3a01783c8f.png)
   
   
![image](https://user-images.githubusercontent.com/51938049/89276878-bc307a00-d676-11ea-8c44-4c42e2202feb.png)
   
   ## What is the link to the Apache JIRA
   
   https://issues.apache.org/jira/browse/RATIS-1018
   
   ## How was this patch tested?
   
   No need to add unit tests.
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to