cyrus-jackson commented on a change in pull request #148:
URL: https://github.com/apache/incubator-ratis/pull/148#discussion_r465464009
##########
File path:
ratis-server/src/main/java/org/apache/ratis/server/RaftServerConfigKeys.java
##########
@@ -50,9 +50,21 @@ static void setStorageDir(RaftProperties properties,
List<File> storageDir) {
setFiles(properties::setFiles, STORAGE_DIR_KEY, storageDir);
}
- String REMOVED_GROUPS_DIR_KEY = STORAGE_DIR_KEY + ".removed.groups.dir";
+ String MOVE_REMOVED_GROUPS_ENABLED_KEY = PREFIX
+ + ".move.removed.groups.enabled";
+ boolean MOVE_REMOVED_GROUPS_ENABLED_DEFAULT = false;
+ static boolean moveRemovedGroupsEnabled(RaftProperties properties) {
+ return getBoolean(properties::getBoolean, MOVE_REMOVED_GROUPS_ENABLED_KEY,
+ MOVE_REMOVED_GROUPS_ENABLED_DEFAULT, getDefaultLog());
+ }
+ static void setMoveRemovedGroupsEnabled(RaftProperties properties,
+ boolean shouldMoveRemovedGroups) {
+ setBoolean(properties::setBoolean, MOVE_REMOVED_GROUPS_ENABLED_KEY,
+ shouldMoveRemovedGroups);
+ }
Review comment:
Done. I have removed this and added renameDirectory
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
