runzhiwang commented on pull request #161: URL: https://github.com/apache/incubator-ratis/pull/161#issuecomment-669657731
> the follower is not in the conf. > I cannot see this requirement in the paper. Could you give me a pointer? @szetszwo You are right, it does not exist in the paper. I implement it to adapt current ratis implementation. Because in current ratis, when leader election, leader will send shutdown to follower if follower, such as follower1, is not in leader's conf at [shouldSendShutdown(candidateId, candidateLastEntry)](https://github.com/apache/incubator-ratis/blob/master/ratis-server/src/main/java/org/apache/ratis/server/impl/RaftServerImpl.java#L860). So I have two choice to make follower1 shutdown: 1.pass the pre-vote in this case, so that follower1 can shutdown in real leader election; 2.pre-vote in charge of shutdown follower1, but this will make pre-vote complicated. So I choose the first option. What do you think? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
