lokeshj1703 commented on pull request #170: URL: https://github.com/apache/incubator-ratis/pull/170#issuecomment-671261126
> With/without this change, UT still work means that the complete purge logic is not properly tested, right? Can you point me to which UT is covering purge logic? @amaliujia Please check TestSegmentedRaftLog. Purge currently considers cached segments for purging and currently in code we are evicting the cache. This leads to scenarios where segments are never purged. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
