amaliujia edited a comment on pull request #194:
URL: https://github.com/apache/incubator-ratis/pull/194#issuecomment-691861144
> @amaliujia Thanks the patch. But how response == null happens ?
This is more like a pre-defence check. The NULL can happen when a new value
added to the ENUM but the code in the SWITCH is not updated. I think it is
always good to eliminate potential NPE.
Alternately, we can choose to throw an exception for a new type, WDYT?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
