amaliujia commented on a change in pull request #199:
URL: https://github.com/apache/incubator-ratis/pull/199#discussion_r488067419
##########
File path:
ratis-common/src/main/java/org/apache/ratis/protocol/RaftGroupMemberId.java
##########
@@ -33,6 +37,12 @@ public static RaftGroupMemberId valueOf(RaftPeerId peerId,
RaftGroupId groupId)
private final RaftGroupId groupId;
private final String name;
+ private RaftGroupMemberId(RaftPeerId peerId, RaftGroupId groupId, int
numMembers) {
+ this.peerId = Objects.requireNonNull(peerId, "peerId == null");
+ this.groupId = Objects.requireNonNull(groupId, "groupId == null");
+ this.name = "p:" + peerId + "@g:" + groupId + "@s:" + numMembers;
Review comment:
Nit: should `@n` be used for `numMembers`? `n` means number. What `s`
stands for?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
