amaliujia commented on a change in pull request #201:
URL: https://github.com/apache/incubator-ratis/pull/201#discussion_r489114114



##########
File path: 
ratis-test/src/test/java/org/apache/ratis/grpc/TestGrpcOutputStream.java
##########
@@ -31,9 +32,7 @@
 
 /**
  * Test {@link GrpcOutputStream}
- * TODO: {@link GrpcOutputStream} current has some bugs.
  */
-@Ignore

Review comment:
       @runzhiwang I wasn't clear enough before:
   
   both `testKillLeader` and `testSimpleWrite` are not a case of transient 
failures. They failed deterministic. 
   
   This PR fixed the root cause of `testSimpleWrite` and RATIS-1065 will track 
the fix for `testKillLeader`
   
   I will fix both RATIS-1065 and RATIS-1064 to move them out of the category 
of transient failures to make it more clear.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to