amaliujia commented on a change in pull request #207:
URL: https://github.com/apache/incubator-ratis/pull/207#discussion_r494742389
##########
File path:
ratis-grpc/src/main/java/org/apache/ratis/grpc/server/GrpcLogAppender.java
##########
@@ -85,17 +85,24 @@ private GrpcServerProtocolClient getClient() throws
IOException {
return rpcService.getProxies().getProxy(getFollowerId());
}
- private synchronized void resetClient(AppendEntriesRequest request) {
+ private synchronized void resetClient(AppendEntriesRequest request, boolean
onError) {
rpcService.getProxies().resetProxy(getFollowerId());
appendLogRequestObserver = null;
firstResponseReceived = false;
// clear the pending requests queue and reset the next index of follower
+ pendingRequests.clear();
+
final long nextIndex = 1 + Optional.ofNullable(request)
.map(AppendEntriesRequest::getPreviousLog)
.map(TermIndex::getIndex)
.orElseGet(getFollower()::getMatchIndex);
- pendingRequests.clear();
+
+ if (onError && getFollower().getMatchIndex() == 0 && request == null) {
+ LOG.warn("{}: Leader has not got in touch with Follower {} yet, " +
+ "just keep nextIndex unchanged and retry.", this, getFollower());
Review comment:
Will retry keeps happening it keeps `onError`?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
