amaliujia commented on a change in pull request #208:
URL: https://github.com/apache/incubator-ratis/pull/208#discussion_r494736402
##########
File path:
ratis-logservice/src/main/java/org/apache/ratis/logservice/tool/VerificationTool.java
##########
@@ -176,6 +176,7 @@ public static void main(String[] args) throws IOException {
}
waitForCompletion(futures);
}
+ client.close();
Review comment:
Because client implements `AutoCloseable`, so it has a `close()`
function should be called.
##########
File path:
ratis-logservice/src/main/java/org/apache/ratis/logservice/tool/VerificationTool.java
##########
@@ -176,6 +176,7 @@ public static void main(String[] args) throws IOException {
}
waitForCompletion(futures);
}
+ client.close();
Review comment:
@runzhiwang Yes. Pushed a commit to use try-with-resources pattern.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
