runzhiwang commented on a change in pull request #213:
URL: https://github.com/apache/incubator-ratis/pull/213#discussion_r499970362
##########
File path:
ratis-test/src/test/java/org/apache/ratis/datastream/TestDataStream.java
##########
@@ -37,34 +39,68 @@
public class TestDataStream extends BaseTest {
- private RaftPeer[] peers;
+ private List<RaftPeer> peers;
private RaftProperties properties;
- private DataStreamServerImpl server;
+ private List<DataStreamServerImpl> servers;
private DataStreamClientImpl client;
private List<CompletableFuture<DataStreamReply>> futures = new ArrayList<>();
public void setupServer(){
- server = new DataStreamServerImpl(peers[0], properties, null);
- server.getServerRpc().startServer();
+ servers = new ArrayList<>(peers.size());
+ // start stream servers on raft peers.
+ for (int i = 0; i < peers.size(); i++) {
+ if (i == 0) {
+ // only the first server routes requests to peers.
+ List<RaftPeer> otherPeers = new ArrayList<>(peers);
+ otherPeers.remove(peers.get(i));
+ DataStreamServerImpl streamServer =
+ new DataStreamServerImpl(peers.get(i), properties, null,
otherPeers);
+ servers.add(streamServer);
+ streamServer.getServerRpc().startServer();
+ } else {
+ DataStreamServerImpl streamServer =
+ new DataStreamServerImpl(peers.get(i), properties, null);
+ servers.add(streamServer);
+ streamServer.getServerRpc().startServer();
+ }
Review comment:
DataStreamServerImpl streamServer;
if (i == 0) {
// only the first server routes requests to peers.
List<RaftPeer> otherPeers = new ArrayList<>(peers);
otherPeers.remove(peers.get(i));
streamServer =
new DataStreamServerImpl(peers.get(i), properties, null,
otherPeers);
} else {
streamServer =
new DataStreamServerImpl(peers.get(i), properties, null);
}
servers.add(streamServer);
streamServer.getServerRpc().startServer();
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
