runzhiwang commented on a change in pull request #213:
URL: https://github.com/apache/incubator-ratis/pull/213#discussion_r502275647
##########
File path:
ratis-netty/src/main/java/org/apache/ratis/netty/server/NettyServerStreamRpc.java
##########
@@ -91,6 +106,11 @@ private void writeTo(ByteBuf buf, DataStream stream,
boolean released) {
throw new CompletionException(t);
}
}
+
Review comment:
I think we can do `channel.write(buffer);` and
`streamOutput.streamAsync(buf.nioBuffer());` in parallel,
`channel.write(buffer)` maybe slow when write file. But not sure, just a
discussion.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
