szetszwo commented on a change in pull request #225:
URL: https://github.com/apache/incubator-ratis/pull/225#discussion_r508242484
##########
File path:
ratis-netty/src/main/java/org/apache/ratis/netty/server/NettyServerStreamRpc.java
##########
@@ -121,29 +146,30 @@ private void sendReply(DataStreamRequestByteBuf request,
ChannelHandlerContext c
private ChannelInboundHandler getServerHandler(){
return new ChannelInboundHandlerAdapter(){
@Override
- public void channelRead(ChannelHandlerContext ctx, Object msg) {
+ public void channelRead(ChannelHandlerContext ctx, Object msg) throws
IOException {
Review comment:
Let's make streaming working first and ignore exception handling for the
moment. We will work on exception handling in separated issues. (Just like
that we separated the retrying in this issue and didn't want RATIS-1082
becoming to big.)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
